dstandish commented on a change in pull request #16821:
URL: https://github.com/apache/airflow/pull/16821#discussion_r664911695
##########
File path: airflow/providers/amazon/aws/hooks/s3.py
##########
@@ -269,6 +270,9 @@ def list_keys(
delimiter: Optional[str] = None,
page_size: Optional[int] = None,
max_items: Optional[int] = None,
+ start_after_key: Optional[str] = '',
Review comment:
I think `None` is the standard default for optional string. I think
this is the most intuitive approach, compared with empty string.
Then you can you can add the parameter only conditionally to `paginate`. To
me it makes sense to only specify parameters when you actually want to use
them. `None` is a good default to mean, "do not use this param" (unless
supplying `StartAfter=None` in paginate has the same effect as omitting it, in
which case leaving it in is fine).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
