sunank200 commented on a change in pull request #16821:
URL: https://github.com/apache/airflow/pull/16821#discussion_r667641239
##########
File path: airflow/providers/amazon/aws/hooks/s3.py
##########
@@ -292,18 +302,24 @@ def list_keys(
'PageSize': page_size,
'MaxItems': max_items,
}
-
paginator = self.get_conn().get_paginator('list_objects_v2')
response = paginator.paginate(
- Bucket=bucket_name, Prefix=prefix, Delimiter=delimiter,
PaginationConfig=config
+ Bucket=bucket_name,
+ Prefix=prefix,
+ Delimiter=delimiter,
+ PaginationConfig=config,
+ StartAfter=start_after_key,
+ )
+ # JMESPath to query directly on paginated results
+ filtered_response = response.search(
Review comment:
When `StartAfter` is `None`, `paginator.paginate()` doesn't use it as
filter. It filters on `StartAfter` only when it's not a `None`. So, filtering
works in both the conditions when it's `None` and not `None`. But like you
have suggested above, I will add a condition to using the parameters only when
passed by the user as argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
