kaxil commented on a change in pull request #16685:
URL: https://github.com/apache/airflow/pull/16685#discussion_r670027434
##########
File path: tests/providers/amazon/aws/operators/test_ecs.py
##########
@@ -349,6 +349,111 @@ def test_reattach_successful(self, launch_type, tags,
start_mock, check_mock, wa
check_mock.assert_called_once_with()
assert self.ecs.arn ==
'arn:aws:ecs:us-east-1:012345678910:task/d8c67b3c-ac87-4ffe-a847-4785bc3a8b55'
+ @parameterized.expand(
+ [
+ ['EC2', None],
+ ['FARGATE', None],
+ ['EC2', {'testTagKey': 'testTagValue'}],
+ ['', {'testTagKey': 'testTagValue'}],
+ ]
+ )
+ @mock.patch.object(ECSOperator, "_xcom_del")
+ @mock.patch.object(
+ ECSOperator,
+ "xcom_pull",
+
return_value="arn:aws:ecs:us-east-1:012345678910:task/d8c67b3c-ac87-4ffe-a847-4785bc3a8b55",
+ )
+ @mock.patch.object(ECSOperator, '_wait_for_task_ended')
+ @mock.patch.object(ECSOperator, '_check_success_task')
+ @mock.patch.object(ECSOperator, '_start_task')
+ def test_reattach_successful(
Review comment:
There is already a test with the same name on L349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
