john-jac commented on a change in pull request #16956:
URL: https://github.com/apache/airflow/pull/16956#discussion_r671308811



##########
File path: airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py
##########
@@ -30,7 +30,8 @@ class SparkKubernetesOperator(BaseOperator):
         For more detail about Spark Application Object have a look at the 
reference:
         
https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/blob/v1beta2-1.1.0-2.4.5/docs/api-docs.md#sparkapplication
 
-    :param application_file: filepath to kubernetes custom_resource_definition 
of sparkApplication
+    :param application_file: either 1) a file ending in '.yaml', '.yml', or 
'.json' that will be converted to the file's string contents by the templating, 
or
+                                    2) a JSON string defining kubernetes 
custom_resource_definition of sparkApplication

Review comment:
       Thanks!  I've updated.  Per 
https://github.com/kubernetes-client/python/blob/master/kubernetes/docs/CustomObjectsApi.md#create_namespaced_custom_object,which
 is what's ultimately called, I don't think YAML is supported, just JSON




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to