BShraman opened a new pull request #17098:
URL: https://github.com/apache/airflow/pull/17098


   Added return code check to minimized writing to txt file in every loop. 
   
   **This request is just to review below changes** . 
   I have added two different version for return code check logic. Both of 
those should produce the similar results . 
   V1 : This is recommended code , but wont be able to print return code from 
the command line.  
   V2 : Eval function should be avoided , as it might manipulate the input . 
But returned code can be printed in log file. 
   
   Any thoughts ?  I will be resubmitting clean merge request, once we agreed 
on the logic. 
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to