potiuk commented on pull request #17098:
URL: https://github.com/apache/airflow/pull/17098#issuecomment-884795196


   > I'd like to hear more details about what exactly you're trying to achieve 
here. You seem to be looking for cases where the scheduler is exiting 
gracefully with a zero exit code and you'd like to **not** log or sleep in 
those cases. Is that right? I wonder if the process exits gracefully in this 
way if we should be restarting it at all? Or perhaps in that case the user 
truly wanted the process to stop.
   
   I agree here with @o-nikolas - I think it would be great also to exit when 
scheduler exits gracefully. I am not sure, however if there is such case 
altogether. Usually that should be done when scheduler gets TERM signal and 
manages to complete everything and quit. Then it should not be restarted. In 
fact the purpose of the script is also unclear to me. It is part of the 
codebase, but it's neither used nor mentioned anywhere in the documentation. So 
if we are changing it, I guess we should also mention how it should be used  
(in charts? In docker compose? elsewhere?), why we cannot use the existing 
deployment mechanisms for that and what is the characteristics of this script - 
i.e. should it really run in a loop regardles of the exit code?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to