uranusjr commented on a change in pull request #17144:
URL: https://github.com/apache/airflow/pull/17144#discussion_r674813319
##########
File path: docs/apache-airflow/concepts/dags.rst
##########
@@ -337,7 +337,7 @@ However, this is just the default behaviour, and you can
control it using the ``
* ``none_failed``: All upstream tasks have not ``failed`` or
``upstream_failed`` - that is, all upstream tasks have succeeded or been skipped
* ``none_failed_or_skipped``: All upstream tasks have not ``failed`` or
``upstream_failed``, and at least one upstream task has succeeded.
* ``none_skipped``: No upstream task is in a ``skipped`` state - that is, all
upstream tasks are in a ``success``, ``failed``, or ``upstream_failed`` state
-* ``dummy``: No dependencies at all, run this task at any time
+* ``null``: No dependencies at all, run this task at any time
Review comment:
Personally I prefer a special null/none trigger rule instead of using
Python’s None directly. None makes every type annotation more difficult
(`Optional` everywhere) and causes bugs more easily (None is used by a lot of
code as the sentinel). The latter is not as significant for Airflow since
`TriggerRule` values are plain strings anyway, but the former point still
stands; `Optional[str]` everywhere is cumbersome in many ways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
