o-nikolas commented on a change in pull request #17144:
URL: https://github.com/apache/airflow/pull/17144#discussion_r675000814
##########
File path: docs/apache-airflow/concepts/dags.rst
##########
@@ -337,7 +337,7 @@ However, this is just the default behaviour, and you can
control it using the ``
* ``none_failed``: All upstream tasks have not ``failed`` or
``upstream_failed`` - that is, all upstream tasks have succeeded or been skipped
* ``none_failed_or_skipped``: All upstream tasks have not ``failed`` or
``upstream_failed``, and at least one upstream task has succeeded.
* ``none_skipped``: No upstream task is in a ``skipped`` state - that is, all
upstream tasks are in a ``success``, ``failed``, or ``upstream_failed`` state
-* ``dummy``: No dependencies at all, run this task at any time
+* ``null``: No dependencies at all, run this task at any time
Review comment:
I like `None`/`"None"` better than `null` for sure.
But just to hammer my original point home a bit more: the other names are
much more explicit and grammatical, e.g. *"trigger when all_succeeded"* or
*"trigger when one_failed"*. From reading the name it's very clear what the
behaviour is. But *"trigger when None"* feels a bit out of place and quite
vague. To me something like *"trigger immediately"* or *"trigger when now"* are
even more descriptive of how the trigger actually behaves and matches the other
trigger names more closely.
But if I'm still out voted I think `None` is a significant improvement :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
