uranusjr commented on a change in pull request #17236:
URL: https://github.com/apache/airflow/pull/17236#discussion_r678047903
##########
File path: airflow/providers/ssh/hooks/ssh.py
##########
@@ -101,7 +103,8 @@ def __init__(
password: Optional[str] = None,
key_file: Optional[str] = None,
port: Optional[int] = None,
- timeout: int = 10,
+ timeout: Optional[int] = 10,
Review comment:
Is this change needed/correct? I feel we want to either change the
default to `None` (so we can better detect whether `timeout` is passed in by
the user), or the type should continue to be `int` (since the user shouldn’t do
`timeout=None` in any situation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
