fatmumuhomer commented on a change in pull request #17236:
URL: https://github.com/apache/airflow/pull/17236#discussion_r678255423
##########
File path: airflow/providers/ssh/hooks/ssh.py
##########
@@ -101,7 +103,8 @@ def __init__(
password: Optional[str] = None,
key_file: Optional[str] = None,
port: Optional[int] = None,
- timeout: int = 10,
+ timeout: Optional[int] = 10,
Review comment:
Yeah, looking at it again you're right. It should default to None
otherwise the user will need to purposefully pass timeout = None to turn off
the deprecation warning.
In order to maintain backwards compatibility, since the current versions of
the hook/operator allow the user to omit timeout, I'll need to handle a
situation where no timeout is passed and set the default later in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
