enima2684 opened a new pull request #17474:
URL: https://github.com/apache/airflow/pull/17474


   This PR adds the following functionality to the DockerSwarmOperator : 
   - support for setting secrets and configs exposed to the started service
   - support for specifying networks that can be joined by the containers of 
the service
   - support for specifying the number of replicas for the swarm service
   
   This features are essential in order to run the DockerSwarmOperator on a 
production environment with shared secrets, configs and networks.
   
   The issue #7955 also mentions the need  for this features.
   
   P.S: this is my first contribution to Airflow. Tried to follow the 
contribution guidelines. Forgive any missed step and looking forward for your 
feedback !
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to