uranusjr commented on a change in pull request #17474:
URL: https://github.com/apache/airflow/pull/17474#discussion_r685170203
##########
File path: airflow/providers/docker/operators/docker_swarm.py
##########
@@ -121,12 +153,16 @@ def _run_service(self) -> None:
env=self.environment,
user=self.user,
tty=self.tty,
+ configs=self.configs,
+ secrets=self.secrets,
),
restart_policy=types.RestartPolicy(condition='none'),
resources=types.Resources(mem_limit=self.mem_limit),
+ networks=self.networks,
),
name=f'airflow-{get_random_string()}',
labels={'name': f'airflow__{self.dag_id}__{self.task_id}'},
+ mode=types.ServiceMode(mode=self.mode, replicas=self.replicas),
Review comment:
Yeah that’s a good policy, and I would have recommended the same
normally. But we are already exposing `ConfigReference` and `SecretReference`
and tie-coupling to Docker.py, so it’s not very meaningful to not expose it
anymore. If we want to hide it, we need to wrap *all* the configurations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
