subkanthi commented on a change in pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#discussion_r689071238



##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -287,7 +287,8 @@ def reconcile_specs(
             client_spec.containers = PodGenerator.reconcile_containers(
                 base_spec.containers, client_spec.containers
             )
-            merged_spec = extend_object_field(base_spec, client_spec, 
'volumes')
+            merged_spec = extend_object_field(base_spec, client_spec, 
'init_containers')
+            merged_spec = extend_object_field(base_spec, merged_spec, 
'volumes')

Review comment:
       can this be renamed to merged_volume_spec and merged_init_container_spec 
for clarity.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to