uranusjr commented on a change in pull request #17654:
URL: https://github.com/apache/airflow/pull/17654#discussion_r690927981
##########
File path: airflow/task/task_runner/standard_task_runner.py
##########
@@ -110,7 +110,6 @@ def terminate(self):
return
# Reap the child process - it may already be finished
Review comment:
This comment should be removed if we’re removing the line below.
##########
File path: airflow/task/task_runner/standard_task_runner.py
##########
@@ -110,7 +110,6 @@ def terminate(self):
return
# Reap the child process - it may already be finished
Review comment:
I *think* this comment specifically means reaping `self.process` (if
it’s already finished). The block below is reaping the process *group* managed
by `self.process` if it has not finished yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
