ephraimbuddy commented on a change in pull request #17654:
URL: https://github.com/apache/airflow/pull/17654#discussion_r690949248
##########
File path: airflow/task/task_runner/standard_task_runner.py
##########
@@ -110,7 +110,6 @@ def terminate(self):
return
# Reap the child process - it may already be finished
Review comment:
I think it’s for the code below it where the process group was reaped?
##########
File path: airflow/task/task_runner/standard_task_runner.py
##########
@@ -110,7 +110,6 @@ def terminate(self):
return
# Reap the child process - it may already be finished
Review comment:
Looks like it. Thanks
##########
File path: airflow/task/task_runner/standard_task_runner.py
##########
@@ -110,7 +110,6 @@ def terminate(self):
return
# Reap the child process - it may already be finished
- _ = self.return_code(timeout=0)
Review comment:
No problem. Just fixing the test but we can as well go with the solution
I have at https://github.com/apache/airflow/pull/17581.
##########
File path: airflow/task/task_runner/standard_task_runner.py
##########
@@ -110,7 +110,6 @@ def terminate(self):
return
# Reap the child process - it may already be finished
- _ = self.return_code(timeout=0)
Review comment:
Thanks for the link!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
