josh-fell commented on a change in pull request #16866:
URL: https://github.com/apache/airflow/pull/16866#discussion_r691502569
##########
File path: airflow/example_dags/tutorial_taskflow_api_etl_virtualenv.py
##########
@@ -19,24 +19,14 @@
# [START tutorial]
# [START import_module]
-import json
-
from airflow.decorators import dag, task
from airflow.utils.dates import days_ago
# [END import_module]
-# [START default_args]
-# These args will get passed on to each operator
-# You can override them on a per-task basis during operator initialization
Review comment:
@ephraimbuddy We still have an explanation in the `tutorial.py` example
DAG.
```python
# [START default_args]
# These args will get passed on to each operator
# You can override them on a per-task basis during operator initialization
default_args = {
'owner': 'airflow',
'depends_on_past': False,
'email': ['[email protected]'],
'email_on_failure': False,
'email_on_retry': False,
'retries': 1,
'retry_delay': timedelta(minutes=5),
# 'queue': 'bash_queue',
# 'pool': 'backfill',
# 'priority_weight': 10,
# 'end_date': datetime(2016, 1, 1),
# 'wait_for_downstream': False,
# 'dag': dag,
# 'sla': timedelta(hours=2),
# 'execution_timeout': timedelta(seconds=300),
# 'on_failure_callback': some_function,
# 'on_success_callback': some_other_function,
# 'on_retry_callback': another_function,
# 'sla_miss_callback': yet_another_function,
# 'trigger_rule': 'all_success'
}
# [END default_args]
```
When I go through the example DAGs again for Taskflow API updates, I'll see
what applicable `default_args` use I can sprinkle in too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
