josh-fell commented on a change in pull request #16866:
URL: https://github.com/apache/airflow/pull/16866#discussion_r691507023
##########
File path: airflow/example_dags/tutorial_taskflow_api_etl_virtualenv.py
##########
@@ -19,24 +19,14 @@
# [START tutorial]
# [START import_module]
-import json
-
from airflow.decorators import dag, task
from airflow.utils.dates import days_ago
# [END import_module]
-# [START default_args]
-# These args will get passed on to each operator
-# You can override them on a per-task basis during operator initialization
Review comment:
Whether or not that is a _good_ example is another question though.
There is a lot of blind copy/paste by users in DAG files and maybe it makes
sense to update the documentation to list these out in an explicit table rather
than hiding in DAG code.
We've been trying to improve the `default_args` use (e.g. not specifying
default `default_args` and/or moving useful/applicable `default_args`
assignment directly to the `DAG()` instantiation). I could definitely add this
table as part of the upcoming PR for example DAGs if you agree on this approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
