ashb commented on a change in pull request #17719:
URL: https://github.com/apache/airflow/pull/17719#discussion_r692770126
##########
File path: tests/executors/test_celery_executor.py
##########
@@ -363,8 +360,8 @@ def test_check_for_stalled_adopted_tasks(self):
task_1 = BaseOperator(task_id="task_1", start_date=start_date)
task_2 = BaseOperator(task_id="task_2", start_date=start_date)
- key_1 = TaskInstanceKey(dag.dag_id, task_1.task_id, exec_date,
try_number)
- key_2 = TaskInstanceKey(dag.dag_id, task_2.task_id, exec_date,
try_number)
+ key_1 = TaskInstanceKey(dag.dag_id, task_1.task_id, "runid",
try_number)
+ key_2 = TaskInstanceKey(dag.dag_id, task_2.task_id, "runid",
try_number)
Review comment:
Might be worth it, yes. Two reasons I did this: it was late, and nothing
in the Executor cares about DagRun or strictly speaking executor_date.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
