ashb commented on a change in pull request #17719:
URL: https://github.com/apache/airflow/pull/17719#discussion_r692877410
##########
File path: airflow/jobs/backfill_job.py
##########
@@ -645,16 +645,14 @@ def tabulate_ti_keys_set(set_ti_keys:
Set[TaskInstanceKey]) -> str:
# Sorting by execution date first
sorted_ti_keys = sorted(
set_ti_keys,
- key=lambda ti_key: (ti_key.execution_date, ti_key.dag_id,
ti_key.task_id, ti_key.try_number),
+ key=lambda ti_key: (ti_key.run_id, ti_key.dag_id,
ti_key.task_id, ti_key.try_number),
Review comment:
https://docs.sqlalchemy.org/en/13/orm/loading_relationships.html?highlight=joinedload#sqlalchemy.orm.contains_eager
may be useful in various places (`joinedload` would join against the table
_twice_)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
