kaxil commented on pull request #17745: URL: https://github.com/apache/airflow/pull/17745#issuecomment-902974705
> I am afraid this is going to fail if someone tries to run it with Airflow < 2.2. We should add some if's here as the docker-compose for quite some time will be used also for older versions of airflow. Why would someone use this > I am afraid this is going to fail if someone tries to run it with Airflow < 2.2. We should add some if's here as the docker-compose for quite some time will be used also for older versions of airflow. Docker-compose does not support conditionals for spinning up services. The only workaround is exiting with `exit 0` in which case you lose health-check benefits. Plus docker-compose files are versioned with Airflow, users can use docker-compose file for that version . The command to get docker-compose is https://airflow.apache.org/docs/apache-airflow/stable/start/docker.html: ``` curl -LfO 'https://airflow.apache.org/docs/apache-airflow/2.1.2/docker-compose.yaml' ``` The same reason why a user shouldn't be using older version of Airflow and looking into new docs should apply here. Plus this is for local testing only, our Helm Chart already have this conditionals. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
