potiuk edited a comment on pull request #17745:
URL: https://github.com/apache/airflow/pull/17745#issuecomment-902985606


   > 
   > The command to get docker-compose is 
https://airflow.apache.org/docs/apache-airflow/stable/start/docker.html:
   > 
   > ```
   > curl -LfO 
'https://airflow.apache.org/docs/apache-airflow/2.1.2/docker-compose.yaml'
   > ```
   
   I've been helping users with ~30 issues over the last few weeks. Some of 
them jus took the latest docker-compose and changed the version and run it. The 
problem is that you get to the "quick-start" page and download the file from 
there. And then they look at it, change the version to 2.0.2 ("why? Because 
this is the version that is installed in my production, I wanted to use the 
same"). They will not switch to earlier version of airlfow in the docs, they 
will not use the right command for the version. They just don't.
   
   The file itself has no indication which version it supports, it's not named 
docker-compose-2.1.2 or anything like that, just docker compose. I simply do 
not want any more to close people's issues beginning with "I used your official 
docker compose and it does not work". In this case the error will be cryptic 
ant the user will not know what to do "the triggerrer command  will fail". 
   
   The "quick-start" should be really "quick" and should give the users maximum 
guidance on how they should fix the problems, Almost by definition, the users 
of "quick-start" docker compose know nothing about airflow, and when they will 
see an error - which they won't understand, they will ... open an issue. I do 
not want this. I am currently on a spree of making sure we optimise our issue 
opening/handling experience. The best way to deal with issues is to make sure 
they will not get opened in the first place.
   
   This is why few lines down I've added explicit "fail if the version is < 
2.1.0 and tell them to use only newer version. Either we make this docker 
compose 2.2.0+ (and change the min version below so that user will get explicit 
"please upgrade message in case they use < 2.2.0) - which is fine, for me as 
the message will be clear. Or we introduce some kind of backwards 
compatibility. Either this or that, but "triggerer could not be started" 
instead of "You should upgrade airflow to 2.2.0" is a very bad message for 
first-time users.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to