hbrls opened a new pull request #14535:
URL: https://github.com/apache/airflow/pull/14535
This may not be a ready PR. The code diff best expresses my ideas.
I'm initializing a mysql 5.7 db from empty using `hub.docker.com,
apache/airflow:2.0.1-python3.8`. The migration scripts throw errors of `(1071,
'Specified key was too long; max key length is 767 bytes')`.
`AIRFLOW__CORE__SQL_ENGINE_COLLATION_FOR_IDS: utf8mb3_general_ci` does not
work. (ref #7570).
After go through the issues and code, I had an assumption that `utf8mb3`
config was not applied to all places that it should. I applied those migration
scripts manually, then it works.
I'm not confident about how the migration scripts work.
1. Should it be generated by some tools and not modified manually?
2. Some scripts modify existed columns. Can I directly fix the `create
table` scripts and skip the `modify table` ones? How does this affect the old
users wants to upgrade?
~~Another question.~~
~~I cannot fix the line `bop.create_primary_key('pk_xcom', ['dag_id',
'task_id', 'key', 'execution_date'])`. My DBA always told me not to use too
many columns for keys. Why in this case `dag_id` and `task_id` is not enough?~~
EDIT: Fixed in master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
