nathadfield commented on a change in pull request #18064:
URL: https://github.com/apache/airflow/pull/18064#discussion_r705243210
##########
File path: airflow/providers/hashicorp/hooks/vault.py
##########
@@ -148,9 +149,29 @@ def __init__(
except ValueError:
raise VaultError(f"The version is not an int: {conn_version}.
")
- if auth_type in ["approle", "aws_iam"]:
+ if auth_type == "approle":
+ if not role_id:
+ if self.connection.extra_dejson.get('role_id'):
+ role_id = self.connection.extra_dejson.get('role_id')
+ else:
+ role_id = self.connection.login
+ else:
+ warnings.warn(
+ """The usage of role_id has been deprecated.
+ Please use either the connection login or extras.""",
Review comment:
Ok, so, to clarify. No deprecation of `role_id` for `aws_am` and a
modified warning for `AppRole`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
