potiuk commented on a change in pull request #18064:
URL: https://github.com/apache/airflow/pull/18064#discussion_r706089404
##########
File path: airflow/providers/hashicorp/hooks/vault.py
##########
@@ -148,7 +149,21 @@ def __init__(
except ValueError:
raise VaultError(f"The version is not an int: {conn_version}.
")
- if auth_type in ["approle", "aws_iam"]:
+ if auth_type == "approle":
+ if not role_id:
+ if self.connection.extra_dejson.get('role_id'):
+ role_id = self.connection.extra_dejson.get('role_id')
Review comment:
Almost perfect :).
I think we not only want to warn when uses passes role_id for "approle" but
we also want to deprecate this (pseudo-code):
```
dummy_login:password@host?auth_type="approle"&role_id="nn"
```
we should here raise a similar warning as below and ask users to change it
to:
```
role:password@host?auth_type="approle"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
