fredthomsen commented on a change in pull request #18257:
URL: https://github.com/apache/airflow/pull/18257#discussion_r709463588
##########
File path: chart/templates/webserver/webserver-ingress.yaml
##########
@@ -39,31 +39,38 @@ spec:
{{- if .Values.ingress.web.tls.enabled }}
tls:
- hosts:
- - {{ .Values.ingress.web.host }}
+{{- if .Values.ingress.web.tls.enabled }}
+ {{- range .Values.ingress.web.hosts | default (list
.Values.ingress.web.host) }}
+ - {{ . | quote }}
+ {{- end }}
+{{- end }}
secretName: {{ .Values.ingress.web.tls.secretName }}
{{- end }}
rules:
+ {{- range .Values.ingress.web.hosts | default (list
.Values.ingress.web.host) }}
- http:
paths:
- {{- range .Values.ingress.web.precedingPaths }}
+ {{- range $.Values.ingress.web.precedingPaths }}
- path: {{ .path }}
backend:
serviceName: {{ .serviceName }}
servicePort: {{ .servicePort }}
{{- end }}
- backend:
- serviceName: {{ .Release.Name }}-webserver
+ serviceName: {{ $.Release.Name }}-webserver
servicePort: airflow-ui
-{{- if .Values.ingress.web.path }}
- path: {{ .Values.ingress.web.path }}
+{{- if $.Values.ingress.web.path }}
+ path: {{ $.Values.ingress.web.path }}
{{- end }}
- {{- range .Values.ingress.web.succeedingPaths }}
+ {{- range $.Values.ingress.web.succeedingPaths }}
- path: {{ .path }}
backend:
serviceName: {{ .serviceName }}
servicePort: {{ .servicePort }}
{{- end }}
-{{- if .Values.ingress.web.host }}
- host: {{ .Values.ingress.web.host }}
+
+{{- if . }}
+ host: {{ . | quote }}
{{- end }}
Review comment:
So this conditional was already present in the previous iteration of the
chart. Reading the ingress docs, looks like setting no host matches anything
without a HTTP host header. Now I am not sure if no host entry is the same as
an empty host entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
