fredthomsen commented on a change in pull request #18257:
URL: https://github.com/apache/airflow/pull/18257#discussion_r709472419
##########
File path: chart/templates/webserver/webserver-ingress.yaml
##########
@@ -39,31 +39,38 @@ spec:
{{- if .Values.ingress.web.tls.enabled }}
tls:
- hosts:
- - {{ .Values.ingress.web.host }}
+{{- if .Values.ingress.web.tls.enabled }}
+ {{- range .Values.ingress.web.hosts | default (list
.Values.ingress.web.host) }}
+ - {{ . | quote }}
+ {{- end }}
Review comment:
Actually, I am not seeing this bear out in my testing. Some hostnames
that need quotes are remaining unquoted with the above change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
