uranusjr commented on a change in pull request #18042:
URL: https://github.com/apache/airflow/pull/18042#discussion_r710852660
##########
File path: airflow/utils/email.py
##########
@@ -87,8 +91,10 @@ def send_email_smtp(
"""
smtp_mail_from = conf.get('smtp', 'SMTP_MAIL_FROM')
+ mail_from = smtp_mail_from or from_email
Review comment:
If a user calls this function directly (not via `send_email`), I feel
they should still automatically get `FROM_EMAIL` if `SMTP_MAIL_FROM` is not
set, instead of needing to pass it in manually.
(This also reminds me, should we change the former to `EMAIL_FROM` instead
for consistency? Or maybe even `DEFAULT_FROM` or just `FROM`?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
