uranusjr commented on a change in pull request #18042:
URL: https://github.com/apache/airflow/pull/18042#discussion_r713571942
##########
File path: airflow/utils/email.py
##########
@@ -87,8 +91,10 @@ def send_email_smtp(
"""
smtp_mail_from = conf.get('smtp', 'SMTP_MAIL_FROM')
+ mail_from = smtp_mail_from or from_email
Review comment:
Yes, but I don’t think it’s a bad thing since those functions are
fundamentally different. It also allows a new backend to choose to *not*
respect the `email_from` config if that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
