SamWheating commented on a change in pull request #18431:
URL: https://github.com/apache/airflow/pull/18431#discussion_r714285583
##########
File path: airflow/sensors/sql.py
##########
@@ -90,7 +94,7 @@ def _get_hook(self):
f"Connection type ({conn.conn_type}) is not supported by
SqlSensor. "
+ f"Supported connection types: {list(allowed_conn_type)}"
)
- return conn.get_hook()
+ return conn.get_hook(self.hook_params)
Review comment:
```suggestion
return conn.get_hook(hook_params=self.hook_params)
```
Using a keyword argument might make this more readable and less likely to
break if someone later adds another argument to the `get_hook` function.
However this might be more personal opinion, thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
