kazanzhy commented on a change in pull request #18431:
URL: https://github.com/apache/airflow/pull/18431#discussion_r719374081
##########
File path: airflow/models/connection.py
##########
@@ -289,8 +289,11 @@ def rotate_fernet_key(self):
if self._extra and self.is_extra_encrypted:
self._extra = fernet.rotate(self._extra.encode('utf-8')).decode()
- def get_hook(self):
- """Return hook based on conn_type."""
+ def get_hook(self, hook_params: Dict = {}):
Review comment:
Yeah, I've also had to deal with the problem described in SO.
But in this case, Dict is just a container and hasn't been updated in the
method.
Could you please write an example in the context of SqlSensor when we can
receive the behavior similar to SO?
Because now, in my opinion, it looks like code sophistication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
