Mikhail-M opened a new pull request #18506:
URL: https://github.com/apache/airflow/pull/18506


   As written in section 
https://airflow.apache.org/docs/apache-airflow/stable/concepts/scheduler.html#database-requirements,
 MariaDB higher than 10.6 should work well in HA mode, but has not been tested, 
so I have tested it and it doesn't work because
   1) MariaDB 10.6 doesn't support  update OF, but support NOWAIT and SKIP 
LOCKED well, so in current version of AIRFLOW if condition is wrong -- fixed in 
this PR
   2) SQLAlchemy==1.3.24 knew nothing about MariaDB 10.6 and contains this 
fragment of code 
https://github.com/sqlalchemy/sqlalchemy/blob/rel_1_3_24/lib/sqlalchemy/dialects/mysql/base.py#L1609
 as a result, we get query  without SKIP LOCKED. It works correct in 1.4.0 and 
higher but we can't update this dependency because of 
https://github.com/apache/airflow/issues/14811 (webserver crash). In our 
infrastructure I tested latest version of SQLAlchemy and Scheduler work well, 
but webserver not. 
   
   As far as we merged thin PR and update SQLAlchemy Airflow will support HA 
Schedulers with MariaDB 10.6+
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to