uranusjr commented on a change in pull request #18506:
URL: https://github.com/apache/airflow/pull/18506#discussion_r716144336
##########
File path: airflow/utils/sqlalchemy.py
##########
@@ -177,6 +179,14 @@ def process_result_value(self, value, dialect):
return data
+def _is_dialect_good_for_row_locks(dialect: DefaultDialect) -> bool:
+ supports_for_update_of = dialect.name != "mysql" or
dialect.supports_for_update_of
+ mariadb_10_6 = (
+ isinstance(dialect, MySQLDialect) and dialect._is_mariadb and
dialect.server_version_info >= (10, 6)
+ )
Review comment:
Emm not sure depending on `_is_mariadb` is a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
