khalidmammadov commented on pull request #18667: URL: https://github.com/apache/airflow/pull/18667#issuecomment-932881482
Just a rename. Otherwise, it looks like a some important api function. Rename makes it clear that this is just a test suites related func. On Sun, 3 Oct 2021, 08:22 Tzu-ping Chung, ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In tests/www/test_security.py > <https://github.com/apache/airflow/pull/18667#discussion_r720783766>: > > > - cls.delete_roles() > + cls.delete_test_roles() > > Is this only a simple rename or is delete_roles not technically doable? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/airflow/pull/18667#pullrequestreview-769554181>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ACYJ3NDHVIAPS7RQLEPZHLDUFAADPANCNFSM5FEO2RVQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
