khalidmammadov commented on a change in pull request #18667:
URL: https://github.com/apache/airflow/pull/18667#discussion_r720816747
##########
File path: tests/www/test_security.py
##########
@@ -99,14 +99,33 @@ def setUp(self):
log.debug("Complete setup!")
@classmethod
- def delete_roles(cls):
+ def tearDownClass(cls):
+ cls.delete_test_roles()
+ cls.delete_test_users()
+
+ @classmethod
+ def delete_test_users(cls):
+ method_users = [attr[5:] for attr in cls.__dict__ if attr[:4] ==
'test']
+ adhoc_users = [
+ 'ElUser',
+ 'Monsieur User',
+ 'dag_access_user',
+ 'LaUser',
+ 'dag_permission_user'
+ ]
Review comment:
This is just an incremental change to fix tidy up issue that left by the
test. But if it's better to refactoring of whole suite to pytest then it's
fine, I can close this one can look into the refactoring and fixing it for the
good. I was just trying to avoid big changes and not sure how community likes
it or not. I can add a new suite with similar name with goal to phase out this
one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
