potiuk commented on pull request #18675: URL: https://github.com/apache/airflow/pull/18675#issuecomment-933033822
I ❤️ where it goes. I do not know too well the UI part, and I need to look more at it but it looks so much more usable than the old tree view. I have not looked at the code but I have a few small "UX" comments and improvement proposals: * I'd add is to have slightly different shade of gray background for alternating rows of the same type (same level). This make whole world of difference in "grid-like" view - you immediately see which row value you actually look at if you are looking at far-left column. (this will work without hovering the mouse). * I love the duration though indeed without handling outliers it will be only useful in "non-interesting" cases - where all durations are similiar, so I think handling outliers is absolutely needed., * (might be more difficult) I think we also need some vertical lines for the time spans - nice to have but likely the grid lines should follow the same decision rules as for the time labels. * I think "play" on manual runs is not the best choice. The "play" suggests that it is an "actionable" button. I'd rather use a small "hand" there (akin to https://icon-library.com/icon/icon-manual-2.html), I thnk much more "static" meaning even if it's not the same as "trigger" button. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
