potiuk commented on pull request #18670:
URL: https://github.com/apache/airflow/pull/18670#issuecomment-933346326


   And another clarification here - I do agree it could  be an optional 
feature, but I think this should also be one of the "supported" configuration 
options of Airflow (possibly even described in the docs). Apparently - 
capability of adding the user via UI can be re-added by adding the right 
permission (this is what https://github.com/apache/airflow/discussions/18290 
discussion led to) and I think this might be the right  "Feature":
   
   * the same permission should control the UI/API possibility of adding a user
   * we should describe this feature as "optional" LDAP seeting and valid use 
case and how to set the permission to make it works
   
   That would be perfectly fine. 
   
   I am not sure though how the permissions are granted/set as this part of 
FAB/security manager I am not too familiar with, but I think we should make it 
an optional feature. I was afraid that if we "hard-code" `DB = No adding`, we 
will make this feature not possible to even configure by the user as opt-in. I 
just wanted to raise the case that this is a "valid" use case and it should be 
"possible" to configure (and likely with some guidance from us on how to do it).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to