ashb commented on pull request #18670: URL: https://github.com/apache/airflow/pull/18670#issuecomment-934285200
If the user exists in LDAP, but the password is wrong, then `auth_user_ldap` would return None https://github.com/dpgaspar/Flask-AppBuilder/blob/1fb6d985910d306a821a8da072cd3c93e41311ac/flask_appbuilder/security/manager.py#L1135-L1137 ```python if not self._ldap_bind(ldap, con, bind_username, password): if user: self.update_user_auth_stat(user, False) # Invalid credentials, go away log.info(LOGMSG_WAR_SEC_LOGIN_FAILED.format(bind_username)) return None ``` The more I look at this the more I worry this is a potential security issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
