JavierLopezT commented on a change in pull request #18764:
URL: https://github.com/apache/airflow/pull/18764#discussion_r723014871
##########
File path: airflow/providers/amazon/aws/secrets/secrets_manager.py
##########
@@ -74,22 +74,26 @@ class SecretsManagerBackend(BaseSecretsBackend,
LoggingMixin):
However, these lists can be extended using the configuration parameter
``extra_conn_words``.
:param connections_prefix: Specifies the prefix of the secret to read to
get Connections.
- If set to None (null), requests for connections will not be sent to
AWS Secrets Manager
+ If set to None (null value in the configuration), requests for
connections will not be
+ sent to AWS Secrets Manager. If you don't want a connections_prefix,
set it as an empty string
:type connections_prefix: str
:param variables_prefix: Specifies the prefix of the secret to read to get
Variables.
- If set to None (null), requests for variables will not be sent to AWS
Secrets Manager
+ If set to None (null value in the configuration), requests for
variables will not be sent to
+ AWS Secrets Manager. If you don't want a variables_prefix, set it as
an empty string
:type variables_prefix: str
:param config_prefix: Specifies the prefix of the secret to read to get
Configurations.
- If set to None (null), requests for configurations will not be sent to
AWS Secrets Manager
+ If set to None (null value in the configuration), requests for
configurations will not be sent to
+ AWS Secrets Manager. If you don't want a config_prefix, set it as an
empty string
:type config_prefix: str
:param profile_name: The name of a profile to use. If not given, then the
default profile is used.
:type profile_name: str
:param sep: separator used to concatenate secret_prefix and secret_id.
Default: "/"
:type sep: str
:param full_url_mode: if True, the secrets must be stored as one conn URI
in just one field per secret.
- Otherwise, you can store the secret using different fields (password,
user...)
+ Otherwise, you can store the secret using different fields (password,
user...). For using it
+ as False, set as str "False" in backend_kwargs.
Review comment:
Having the value False. I wanted to point out that you can't pass the
bool `False` to have `full_url_mode=False`, but the string `"False"`. I'll try
to improve the descriptions. Any suggestions anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
