JavierLopezT commented on a change in pull request #18764:
URL: https://github.com/apache/airflow/pull/18764#discussion_r723174073
##########
File path: airflow/providers/amazon/aws/secrets/secrets_manager.py
##########
@@ -74,22 +74,26 @@ class SecretsManagerBackend(BaseSecretsBackend,
LoggingMixin):
However, these lists can be extended using the configuration parameter
``extra_conn_words``.
:param connections_prefix: Specifies the prefix of the secret to read to
get Connections.
- If set to None (null), requests for connections will not be sent to
AWS Secrets Manager
+ If set to None (null value in the configuration), requests for
connections will not be
+ sent to AWS Secrets Manager. If you don't want a connections_prefix,
set it as an empty string
:type connections_prefix: str
:param variables_prefix: Specifies the prefix of the secret to read to get
Variables.
- If set to None (null), requests for variables will not be sent to AWS
Secrets Manager
+ If set to None (null value in the configuration), requests for
variables will not be sent to
+ AWS Secrets Manager. If you don't want a variables_prefix, set it as
an empty string
:type variables_prefix: str
:param config_prefix: Specifies the prefix of the secret to read to get
Configurations.
- If set to None (null), requests for configurations will not be sent to
AWS Secrets Manager
+ If set to None (null value in the configuration), requests for
configurations will not be sent to
+ AWS Secrets Manager. If you don't want a config_prefix, set it as an
empty string
Review comment:
If it's null, then it shouldn't get connections. And this must be
maintained because is what the previous behavior was:
https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/secrets-backends/aws-secrets-manager.html#optional-lookup
https://github.com/apache/airflow/blob/eda538f56cb2dc2728d303acddb42841fe419c36/airflow/providers/amazon/aws/secrets/secrets_manager.py#L57
https://github.com/apache/airflow/blob/eda538f56cb2dc2728d303acddb42841fe419c36/airflow/providers/amazon/aws/secrets/secrets_manager.py#L112-L113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
