potiuk commented on a change in pull request #18883:
URL: https://github.com/apache/airflow/pull/18883#discussion_r726604398
##########
File path: CHANGELOG.txt
##########
@@ -125,6 +125,7 @@ Improvements
- Refactor: ``SKIPPED`` should not be logged again as ``SUCCESS`` (#14822)
- Remove version limits for dnspython (#18046, #18162)
- Accept custom run ID in TriggerDagRunOperator (#18788)
+- Align the default version with Facebook business SDK (#18883)
Review comment:
For now - for provider changes we do NOT expect anyone to change any
changelogs - until we introduce a tool like towncrier, making any rules like
that makes more harm than good - mainly because we have:
a) no agreed rules (quoting google here is nice but I did not recall we took
that as a base)
b) we have no agreement between committers on different rules
c) the release manager of provider (currently mysefl) prepares the changelog.
I do not think we have any rules, more I think introducing any rules,
requires introducing protection and verification that those rules are followed
(otherwise some changes will have it but others will not) - so unless we
document the rules we should follow and have some way for the committers to
make sure the commenrs are added, I think it makes little sense to ask people
to follow such rules which are not documented/agreed.
I think for now it's best to remove the changelog entries, and leave it up
to release manger, but it would be great if someone introduce automation and
verification (I will do it it November, but maybe someone wants to do it
earlier).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
