mik-laj commented on a change in pull request #18883:
URL: https://github.com/apache/airflow/pull/18883#discussion_r726619747



##########
File path: CHANGELOG.txt
##########
@@ -125,6 +125,7 @@ Improvements
 - Refactor: ``SKIPPED`` should not be logged again as ``SUCCESS`` (#14822)
 - Remove  version limits for dnspython (#18046, #18162)
 - Accept custom run ID in TriggerDagRunOperator (#18788)
+- Align the default version with Facebook business SDK (#18883)

Review comment:
       So where do we want to describe the breaking changes? I am afraid that 
the title alone is not enough in many cases. The task manager also often does 
not have enough knowledge to prepare a description of the change that is 
sufficient, because the `git diff` often does not show the full context. The 
preparation of the note also forces us to reflect on whether we really need to 
introduce such a breaking change.(see example: 
https://github.com/apache/airflow/pull/18879#discussion_r726616811)
   Regarding the content of the notes about breaking time, this has been 
discussed in the past, and we have some hints in the main UPDATING.md file.
   
https://github.com/apache/airflow/blob/ab5b2bfca6b5be57a19bdbfe2206319bd2e71ac9/UPDATING.md#L64-L78
   Here is a related discussion: 
https://github.com/apache/airflow/pull/18879#discussion_r726616811




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to