potiuk commented on a change in pull request #18883:
URL: https://github.com/apache/airflow/pull/18883#discussion_r726656326
##########
File path: CHANGELOG.txt
##########
@@ -125,6 +125,7 @@ Improvements
- Refactor: ``SKIPPED`` should not be logged again as ``SUCCESS`` (#14822)
- Remove version limits for dnspython (#18046, #18162)
- Accept custom run ID in TriggerDagRunOperator (#18788)
+- Align the default version with Facebook business SDK (#18883)
Review comment:
You refer to single change done by you in Jan. Since then we had 7
releases of providers which followed different proces and every one of them
would have taken much longer time for coordination, automation if it was not
automated how it is today.
The thing you added then was a single case that did not establish a proces,
way how to do it for scaled number of providers and how to make sure it is
followed. As such - it does not really establishes a "process".
It's an accidental change that is dificutlt to follow in scale, there is no
automation to enforce it, nor maintain, and none of the committers is even
aware what should they tell others when then review a change if they were to
follow it. If it just "done" but not agreed, documented and neither
"automation" is in place to kee'p it nor people involved know that it should be
followed.
Until this is done, this does not exist as a rule. It's just a "single
change'.
It was ok for 1 provider and something you added and it was never documented
how to do it.
Since then there were 6 or 7 waves of providers which were followed using
different process which means I can release 60 providers in maye 1-2 hours. You
are now trying to make a change to it wihich potentially changes it to 6 hours
because relase manager will have to make extra checks on every single change
and reconcile the changelog manually and make sure that every single change has
been either manually added already or automatically incorporated into changelog.
If you reallyy want to fight for it and change the current process - I am
perfectly ok with that - there is a next wave of providers to release in
October. If you would like to take a lead on that and release them, I am all
for changing it now and won't object changing the current approach.
Are you ok with it? Can we count on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
