asaf400 commented on a change in pull request #19027:
URL: https://github.com/apache/airflow/pull/19027#discussion_r730598411
##########
File path: airflow/providers/docker/operators/docker.py
##########
@@ -328,7 +331,7 @@ def _run_image_with_mounts(self, target_mounts,
add_tmp_variable: bool) -> Optio
if self.retrieve_output:
ret = return_value
elif self.do_xcom_push:
- ret = self._get_return_value_from_logs(res_lines, line)
+ ret = self._get_return_value_from_logs(lines, lines[-1])
return ret
Review comment:
@uranusjr
so you were thinking a doing flavor of this,
with the previous suggested edit (removing lines from earlier in the code) ?
it kind of looks bad, because it's too long, but it should work,
Feel free to give another suggestion to make it prettier, I'm missing the
way to prettify it, if that what you meant by removing
_get_return_value_from_logs
```suggestion
return self.cli.logs(container=self.container['Id'],
stdout=True, stderr=True, stream=True) if self.xcom_all else
self.cli.logs(container=self.container['Id'], stdout=True, stderr=True,
stream=True, tail=1)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
