asaf400 commented on a change in pull request #19027:
URL: https://github.com/apache/airflow/pull/19027#discussion_r731258267
##########
File path: airflow/providers/docker/operators/docker.py
##########
@@ -328,7 +331,7 @@ def _run_image_with_mounts(self, target_mounts,
add_tmp_variable: bool) -> Optio
if self.retrieve_output:
ret = return_value
elif self.do_xcom_push:
- ret = self._get_return_value_from_logs(res_lines, line)
+ ret = self._get_return_value_from_logs(lines, lines[-1])
return ret
Review comment:
Maybe, I tested out adding random \n into one of the bash 'echo'
(without -e) commands in my example in the issue discussion,
I tried using logstream.split('\n') but it had undesired results, as some of
the random `\n`'s were converted to newlines in the output, but I forgot to
test splitlines() I guess
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
