ephraimbuddy commented on pull request #19100: URL: https://github.com/apache/airflow/pull/19100#issuecomment-950022723
> While i am usually tempted to do the same 'yeah small change let's do it together' - learned by experience it might bite back and when i feel i need to add ' ... and this change also does this ...' in commit message it is usually a sign we should split. > > There is very little penalty of splitting commits/PR into separate ones. > > And yes i often fail myself to follow this advice. i am.ad guilty as anyone of having more than one change In a logical commit. But i do my best to improve :) Thanks very much, @potiuk. That's very good advice. Please @Bowrna make a separate PR for this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
