dstandish commented on a change in pull request #19267:
URL: https://github.com/apache/airflow/pull/19267#discussion_r738579638
##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -409,16 +407,26 @@ def _value_is_hardcoded_default(cls, attrname: str,
value: Any, instance: Any) -
return True
return False
+ @classmethod
+ def _serialize_param(cls, param: Param):
+ d = param.dump()
+ d['value'] = cls._serialize(d['value'])
+ return d
+
+ @classmethod
+ def _deserialize_param(cls, param: Dict):
+ param_class = import_string(param['__class'])
+ param['value'] = cls._deserialize(param['value'])
+ return param_class(default=param['value'],
description=param['description'])
Review comment:
ok in latest commit i think i fixed my fix, so that it should be no
change to serialization structure. initially i had used `value` but now i
restore `default` as the key. theres just ambiguity because `default` is the
kwarg name, and `value` is the attr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
