jedcunningham commented on a change in pull request #19267:
URL: https://github.com/apache/airflow/pull/19267#discussion_r738684758
##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -409,16 +407,26 @@ def _value_is_hardcoded_default(cls, attrname: str,
value: Any, instance: Any) -
return True
return False
+ @classmethod
+ def _serialize_param(cls, param: Param):
+ param_dict = param.dump()
+ param_dict['default'] = cls._serialize(param_dict.pop('value'))
+ return param_dict
+
+ @classmethod
+ def _deserialize_param(cls, param_dict: Dict):
+ param_class = import_string(param_dict['__class'])
+ param_dict['default'] = cls._deserialize(param_dict['default'])
Review comment:
Should we be doing `_deserialize` on everything in `param_dict`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
