dstandish commented on a change in pull request #19267:
URL: https://github.com/apache/airflow/pull/19267#discussion_r738963140
##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -417,7 +417,10 @@ def _serialize_param(cls, param: Param):
@classmethod
def _deserialize_param(cls, param_dict: Dict):
param_class = import_string(param_dict.pop(Param.CLASS_IDENTIFIER))
- param_kwargs = cls._deserialize(param_dict)
+ try:
+ param_kwargs = cls._deserialize(param_dict)
+ except KeyError:
+ param_kwargs = param_dict
Review comment:
separately though, do we really need to support non-json-serializable
params? this will cause problems, for example when you run trigger dag in the
UI -- probably in that case they _must_ be valid json. so what's the point of
supporting non-json in the default? i think it would be best if we simply
require that params be valid json. if users want to use set operations in
their templates, they can do so in the manner i demonstrated in the reported
issue; and we can still keep the param values themselves json.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
