dstandish commented on a change in pull request #19267:
URL: https://github.com/apache/airflow/pull/19267#discussion_r739259049
##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -417,7 +417,10 @@ def _serialize_param(cls, param: Param):
@classmethod
def _deserialize_param(cls, param_dict: Dict):
param_class = import_string(param_dict.pop(Param.CLASS_IDENTIFIER))
- param_kwargs = cls._deserialize(param_dict)
+ try:
+ param_kwargs = cls._deserialize(param_dict)
+ except KeyError:
+ param_kwargs = param_dict
Review comment:
and another reason to be skeptical of this "fix" -- the big feature here
is that params can have validation logic built-in. but the validation approach
is [json schema
validation](https://json-schema.org/draft/2020-12/json-schema-validation.html),
i.e. it explicitly assumes you are validating json! so why would we allow
params to not be json (or json-serializable).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
