anaynayak commented on a change in pull request #19022:
URL: https://github.com/apache/airflow/pull/19022#discussion_r739637739
##########
File path: airflow/config_templates/airflow_local_settings.py
##########
@@ -194,13 +193,17 @@
DEFAULT_LOGGING_CONFIG['handlers'].update(S3_REMOTE_HANDLERS)
elif REMOTE_BASE_LOG_FOLDER.startswith('cloudwatch://'):
+ create_log_group = conf.getboolean('logging',
'CREATE_CLOUDWATCH_LOG_GROUP', fallback=True)
+ create_log_stream = conf.getboolean('logging',
'CREATE_CLOUDWATCH_LOG_STREAM', fallback=True)
Review comment:
From the original issue, I assumed that the issue was around a
restrictive role since the log group was already created via Terraform. Based
on what you've said, The bits around log stream definitely make sense. I'll
remove that as an option.
If the option to not create the log group isn't required, I can close the PR
and we can create a new one when required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
